Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialAaron Figueroa
2,860 Pointsbankaccount practice challenge is not printing out the correct balance.
I pretty much took the code from the practice video and still this code is not working. what am i doing wrong?
class BankAccount
attr_reader :name
def initialize(name)
@name = name
@transactions = []
add_transaction("Beginning Balance", 0)
end
def debit(description, amount)
add_transaction(description, -amount)
end
def credit(description, amount)
add_transaction(description, amount)
end
def add_transaction(description, amount)
@transactions.push(description: description, amount: amount)
end
def balance
balance = 0.0
@transactions.each do |transaction|
balance += transaction[:amount]
return balance
end
end
end
2 Answers
William Li
Courses Plus Student 26,868 PointsHi, there's a semantic error there, you need to move the return statement outside of the loop block.
def balance
balance = 0.0
@transactions.each do |transaction|
balance += transaction[:amount]
end
return balance # took the return statement out of the loop block
end
Hope it helps, feel free to ask if you have more question, cheers.
Mark Kenney
10,148 PointsWilliam Li is correct. When a function hits a return statement it executes it and sends back the value you specify. So basically your existing code is rerunning the balance after the first transaction amount is added in. It does not continue the loop because it has hit a return statement.