Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Number Game App String length

shubhamkt
shubhamkt
11,675 Points
Posted by shubhamkt
shubhamkt
11,675 Points

bummer

code is not working

strlen.py 
def just_right(s):

    st = []
    while True:
        s= input ("input me")


        if len(st) < 5:
            print("Your string is too short")
            break
        elif len(st) > 5:
            print("Your string is too long")
            break
        else: 
            a= True
            return a
        st.append(s)

1 Answer

Umesh Ravji
Umesh Ravji
42,386 Points
Umesh Ravji
Umesh Ravji
42,386 Points

Hey Shubhamkumartrivedi, I'm not sure what you were trying to do, but you've over complicated things, such as adding a while loop, getting input from the user, and there's also a list in there.

You have the code that is required, but you have to remove all the unnecessary code.

def just_right(s):
    if len(s) < 5:
        return "Your string is too short"  # return the string, not print it out, no break
    elif len(s) > 5:
        return "Your string is too long"  # return the string, not print it out, no break
    else: 
        a = True
        return a  # may as well just return True, no need for variable