Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by jyoti barman
jyoti barman
Courses Plus Student 1,280 Points

Can someone help me with this question?

js/app.js

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems = document.querySelector("#rainbow");
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

1 Answer

David McNeill
David McNeill
44,438 Points
David McNeill
David McNeill
44,438 Points

Hi again!

You just need to change two small things in your code.

let listItems = document.querySelectorAll("#rainbow li");

Changing querySelector to querySelectorAll will return a collection for your for loop. You also need to adjust the selector used from ("#rainbow") to ("#rainbow li").

In your answer you were just selecting the <ul> element, which is not what the challenge was asking. You need to select all of the <li> elements within the <ul>. The code above achieves that using a descendant selector ("#rainbow li"), something you might know from CSS.