Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

Posted by Binyamin Grobman
Binyamin Grobman
9,286 Points

can this code work? rgbColor = 'rgb(' + randomRBG() + ',' +randomRBG() + ',' + randomRBG() + ')';

this is the full code.

var html = '';

var rgbColor;


function randomRBG(){ 
 return   Math.floor(Math.random() * 256 );

}


for(var circle = 0;circle < 10 ; circle 
   +=1){

rgbColor = 'rgb(' + randomRBG() + ',' +randomRBG() + ',' + randomRBG() + ')';

html += '<div style="background-color:' + rgbColor + '"></div>';





}

document.write(html);

2 Answers

Steven Parker
Steven Parker
231,236 Points
Steven Parker
Steven Parker
231,236 Points

There's nothing wrong with this code, but it's not complete if you want it to display something on the page.

To make the results visible, you'd need at least some CSS code to go with it, to give the div elements size and shape so they can be seen.

Rahul Saini
Rahul Saini
4,611 Points
Rahul Saini
Rahul Saini
4,611 Points

```function randomRBG(){ return Math.floor(Math.random() * 256 ); instead of just writing to document use this. document.getElementsByTagName("body").innerHTML = html

Steven Parker
Steven Parker
231,236 Points
Steven Parker
Steven Parker
231,236 Points

Multiplying random by 256 ‍does‍ give you a range from 0 to 255. The random value approaches 1 but never reaches it.