Can this implementation of combo() be the worst possible working example?

Question

```python
def combo(iter1, iter2):
  thelist = []
  for thing in enumerate(iter1):
    thelist.append(([thing[1], iter2[thing[0]]]))
  return thelist
```
It's pretty early for a New Years morning and I'm just not thinking clearly.
There's clearly a better way to do this, I just can't make my brain work.  Seems I'm doing a lot of unnecessary things and there's a cleaner way to get the two iterables synced so I can zip the values together.  That's a WHOLE lot of ugly brackets/parentheses at the end for a simple function.
...and I'm assuming list.append() isn't the only way I could do this, so I don't have to do the funky explicit () around list brackets to create my tuples
Maybe I should check this again after a few glasses of water and another nap...

boog690 · Accepted Answer

```python
combo(['swallow', 'snake', 'parrot'], 'abc')
Output:
[('swallow', 'a'), ('snake', 'b'), ('parrot', 'c')]
If you use list.append(), you'll want to pass it a tuple of new values.
Using enumerate() here can save you a variable or two.
def combo(iter1, iter2):
  tuplist = []
  for index, value in enumerate(iter1):
    tuplist.append((value, iter2[index]))
  return tup_list
```
Here's my "less brackety" implementation.  Same idea as yours, though.

Welcome to the Treehouse Community

Looking to learn something new?

Gavin Ralston

Gavin Ralston

Can this implementation of combo() be the worst possible working example?

1 Answer

boog690

boog690

Gavin Ralston

Gavin Ralston