Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Posted by Sky Lu
Sky Lu
1,260 Points

Code Challenge: Refactor

Actually I really don't understand what does below question mean:

This challenge is a little different. You shouldn't have to write very much code. You probably recognize this code. It's pretty much our shopping_list_2.py from before. I want you to help me with a little refactor, though. Refactoring is when we change code to make it better, often by creating new functions. Create a new function named main that doesn't take any arguments. Move everything from line 22 (show_help()) and below into your new function. You shouldn't have any code that isn't inside of a function.

Especially:

Move everything from line 22 (show_help()) and below into your new function. You shouldn't have any code that isn't inside of a function.

I think just add below codes should be fine:

def main()

2 Answers

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher
Jennifer Nordell
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there, Sky! Yes, you added the function but the instructions say that all remaining code should be inside this function. Remember that anything that goes inside a function will be indented to indicate that it is inside the function and not outside. Essentially, every line after that function declaration should be indented once. Hope this helps! :sparkles:

Marcilio Leite Neto
Marcilio Leite Neto
16,465 Points
Marcilio Leite Neto
Marcilio Leite Neto
16,465 Points

Hey Sky Lu, could you send the whole code that is not passing? Be sure to add the colon after the function definition and to indent the code that belongs to the function.

Sky Lu
Sky Lu
1,260 Points

Hi Marcilio,

Thank u very much for your reply, I've solved the problems by another helper. My issue is I added > main()

at the bottom of the codes, actually the task didn't request for that.

below is the wrong codes I've made:

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():    
show_help()

# make a list to hold onto our items
shopping_list = []

while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)

main()