Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Nitin Sharma
Nitin Sharma
1,035 Points

Code looks fine to me its running fine but in my workspace it is failing, saying make sure all code should be in a funct

Code looks fine to me its running fine but in my workspace it is failing, saying make sure all code should be in a funct

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")
    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():
    show_help()
    # make a list to hold onto our items
    shopping_list = []
    while True:
    # ask for new items
        new_item = input("> ")
        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        add_to_list(shopping_list, new_item)
        show_list(shopping_list)

main()

2 Answers

Taylor Schimek
Taylor Schimek
19,318 Points

The challenge is looking to see that all code is inside a function. The last line main() is not inside a function. While you would need this to run the script in real life, it's causing this challenge to fail. Hope that helps.

Actually, if you put the main() code in the main body itself, it will cause an "infinite loop". If you call a function in the function itself, it will cause recursion.

Instead, you should delete that line of code :+1:

Taylor Schimek
Taylor Schimek
19,318 Points

I meant it should be deleted. I wasn't clear, though. Meant that you'd need the call to main() outside to run the whole thing, but it being outside a function is failing this challenge. Thus, it should be deleted. Sorry, I was vague.

:point_right: The challenge never asked you to call the function explicitly.

Remember that code challenges are very picky and you only should do what they say to do and you should write nothing else.

I hope this helps :grin:

Happy coding! :tada:

:dizzy: ~Alex :dizzy: