code refactoring

Question

Am trying to create a main function which houses all the remaining code from line 22 to line 45

shopping_list.py

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():

    show_help()

# make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
         new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
            break
    elif new_item == 'HELP':
            show_help()
            continue
    elif new_item == 'SHOW':
             show_list(shopping_list)
                continue
    add_to_list(shopping_list, new_item)

    show_list(shopping_list)

Answer 1 · 2018-05-01T16:33:09Z

May 1, 2018 4:33pm

Hi Clainos,

Your problem is indentation. Python is very fussy about how far every line is indented (this is how the Python interpreter understands where things like functions and loops and conditionals end). Even though all the text in your code is the same as the challenge, because you have changed the indentation, the code now functions differently.

For example, in the original code the if is indented 4 spaces from the while. This is how Python knows that the if should be executed in the while loop rather than after the while loop finishes. In your code the if is indented at the same level as while.

I suggest that you restart the challenge to get a clean version of the code, add the function declaration exactly like you did before and then carefully ensure that every line that now belongs in your main function is indented by the same number of characters. Then your code will pass.

Welcome to the Treehouse Community

Looking to learn something new?

Clainos Machemedze

Clainos Machemedze

code refactoring

1 Answer

Alex Koumparos

Alex Koumparos