Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

yoav green
yoav green
8,611 Points

creating a function that returns higher number

Create a new function named max which accepts two numbers as arguments (you can name the arguments, whatever you would like). The function should return the larger of the two numbers.

HINT: You'll need to use a conditional statement to test the 2 parameters to see which is the larger of the two.

THIS IS MY CODE :

function max (firstNumber, secondNumber) { if (firstNumber > secondNumber) { return; firstNumber } else (firstNumber < secondNumber) { return secondNumber; } }

Where am i wrong?

script.js

3 Answers

Halvard Bastiansen
seal-mask
.a{fill-rule:evenodd;}techdegree
Halvard Bastiansen
Data Analysis Techdegree Student 14,886 Points

You dont need the last conditional statement. You dont have a condition for "else", only "else if".

Here is a working code:

function max (firstNumber, secondNumber) { if (firstNumber > secondNumber) { return; firstNumber } else { return secondNumber; } }

yoav green
yoav green
8,611 Points

Thanks for answering. My problem with your code is that there’s a reality of firstnumber = secondnumber

Halvard Bastiansen
seal-mask
.a{fill-rule:evenodd;}techdegree
Halvard Bastiansen
Data Analysis Techdegree Student 14,886 Points

Right, then add a third condition. This time use "else if" with a condition.

function max (firstNumber, secondNumber) { if (firstNumber > secondNumber) { return firstNumber } else if (firstNumber === secondNumber) { // Whatever you want to happen } else { return secondNumber; } }