Don't really know if I understood the instructions correctly

Question

Here's what I tried. It looks OK to me but maybe I did not understand the instructions correctly.

BR, Kimmo

movement.py

# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    X, Y = direction

    while True
        if x+X < 0:
            hp = hp-5
            break
        elif x+X > 9:
            hp = hp-5
            break
        elif y+Y < 0:
            hp = hp-5
            break
        elif y+Y > 9:
            hp = hp-5
            break

    x = x + X
    y = y + Y      

    if x > 9:
        x = 9
    elif x < 0:
        x = 0
    if y > 9:
        y = 9
    elif y < 0:
        y = 0 

    return x, y, hp

Answer 1 · 2017-08-12T05:34:26Z

August 12, 2017 5:34am

There are two issues with using the while loop.

A missing colon after while True is a syntax error
if the new position doesn't go past a wall, then the while loops forever!

You are actually very close. The while loop can be replace with the one of the following:

# use just the if portion
    #while True:
    if x+X < 0:
            hp = hp-5
            # break
    elif x+X > 9:
            hp = hp-5
            #break
    elif y+Y < 0:
            hp = hp-5
            #break
    elif y+Y > 9:
            hp = hp-5
            #break

# or combine the if/elif into a single if:
    if x+X < 0 or x+X > 9 or y+Y < 0 or y+Y > 9:
        hp = hp-5

Answer 2 · 2017-08-12T11:51:30Z

August 12, 2017 11:51am

Thanks Chris! I really appreciate your way of pointing out the things that need to be fixed. It was easy to fix the code after reading your comments.

BR, Kimmo

Welcome to the Treehouse Community

Looking to learn something new?

Kimmo Ojala

Kimmo Ojala

Don't really know if I understood the instructions correctly

2 Answers

Chris Freeman

Chris Freeman

Kimmo Ojala

Kimmo Ojala