Don't understand what is wrong with my code... Please help!

Question

import random
def nchoices(iterate, integer):
  newList = []
  while True:
    newList.append(random.choice(iterate))
    if newList.length == integer:
      break
  return newList
```choices.py
import random
def nchoices(iterate, integer):
  newList = []
  while True:
    newList.append(random.choice(iterate))
    if newList.length == integer:
      break
  return newList
```

Cody Te Awa · Accepted Answer

It appears as though you are trying to access a property from the list class on your list which is the length. To get a length of a list in python you use a function len(). So in this case to get the length of newList you would call len(newList). 
Hope this helps! 
Also just for pythonic coding: You could have that while loop in one statement by having in your while statement, 
while len(newList) < integer: ....etc
just something to ponder (:

Rafael Valera · Answer

You can do it with a for loop too, without having to check for conditions: 
for item in range(integer):
        new_list.append(random.choice(iterable))

Welcome to the Treehouse Community

Looking to learn something new?

Stephen Poole

Stephen Poole

Don't understand what is wrong with my code... Please help!

2 Answers

Cody Te Awa

Cody Te Awa

Stephen Poole

Stephen Poole

Rafael Valera

Rafael Valera