Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Torey Conrad
Torey Conrad
26,411 Points
Posted by Torey Conrad
Torey Conrad
26,411 Points

getElementsByTagName is selecting all 'li' elements in getting handle on the dom challenge 1 0f 3

I cant pass the getting a handle on the dom challenge 1 0f 3 for the life of me. I'm inputing;

var navigationLinks = document.getElementsByTagName('li');

and i get back was expecting 3 not 5. How do get the children li tags of the nav and not get all 5 of the li tags in the HTML doc?

js/app.js 
var navigationLinks = document.getElementsByTagName('li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

2 Answers

andren
andren
28,558 Points
andren
andren
28,558 Points

You use the query selector function, which allow you to use CSS selectors to select elements.

In order to select only li elements that are within a nav element you would use this code:

document.querySelectorAll('nav li');

However it should be noted that selecting all li elements within the nav is not actually what the task is asking you to do, it's asking you to select all links ("a" elements) within the nav. Which requires a selector like this:

document.querySelectorAll('nav a');
Torey Conrad
Torey Conrad
26,411 Points
Torey Conrad
Torey Conrad
26,411 Points

Thanks so much for the help! Using document.querySelectorAll('nav a'); worked like a charm.