Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Mike Gugliuzza
Mike Gugliuzza
8,497 Points
Posted by Mike Gugliuzza
Mike Gugliuzza
8,497 Points

Having trouble with Rainbow querySelector challenge

Hi there, I'm having trouble getting this code to work:

const listItems = document.querySelectorAll('#rainbow'); const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) { listItems[i].style.color = colors[i];
}

Within the HTML side I didn't change anything though I tried assigning the ID to the li elements instead of the ul element.

Thanks!!

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul>
      <li id="rainbow">This should be red</li>
      <li id="rainbow">This should be orange</li>
      <li id="rainbow">This should be yellow</li>
      <li id="rainbow">This should be green</li>
      <li id="rainbow">This should be blue</li>
      <li id="rainbow">This should be indigo</li>
      <li id="rainbow">This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
const listItems = document.querySelectorAll('#rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

2 Answers

Fernando Boza
Fernando Boza
25,384 Points

Remember that querySelectorAll can take in the elements such as ul's, li's, img 's, etc. For this exercise you don't need to add rainbow id to all the elements and FYI, it's extremely bad practice to add the same ID to multiple elements, that what classes are for. but back to your question, you just need to specify in the querySelector all that you want the 'li' elements

let listItems = document.querySelectorAll('li');
Mike Gugliuzza
Mike Gugliuzza
8,497 Points
Mike Gugliuzza
Mike Gugliuzza
8,497 Points

Got it- your code at the end helped alot- thanks!!

jamestoynton
jamestoynton
10,992 Points
jamestoynton
jamestoynton
10,992 Points

Follow up question - what if you need to select only LI elements within a ID ? This would select all Li elements on a page. EDIT: Ignore me ! this would be ("#rainbow li") I think.