Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Austin Huynh
Austin Huynh
4,309 Points

Hello! Is this a good solution to the max() challenge?

Hello! First time I've used the discussion board, so I'm hoping my solution shows!

script.js
function max(firstNumber, secondNumber) {
  if (firstNumber > secondNumber) {
    return firstNumber;
  } else {
    return secondNumber;
  }
}
alert(max(5,10));

2 Answers

Yes it’s a good solution

Jamie Reardon
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Jamie Reardon
Treehouse Project Reviewer

Nothing wrong with it, you created a function with two parameters (which is needed) that are a simple method. It does the job!