Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Posted by Danna Lidia
Danna Lidia
5,933 Points

help with short code

I know it's messy, but it's logical for me. I tried this on Workspace and the code didn't obey the "and". Why is this happening?

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    x1, y1 = direction

    if ((x1 + x) <= 9 and (x1 + x) >= 0) and ((y1 + y) <= 9 and (y1 + y2) >= 0) and (x1 == 1 or x1 == -1) and (y1 == 1 or y1 == -1):
        x += 
        y += y1
    else:
        hp -= 5


    return x, y, hp

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,468 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,468 Points

You are very close. Two typos and two missing conditions

  • missing x1 on the line "x += "
  • using undefined y2 instead of y in `if condition
  • code needs to handle when either x1 or y1 is zero: Add the or'd conditions x1 == 0 and y1 == 0 appropriately.

Post back if you need more help. Good Luck!