How can I improve my code?

There are a few things I'd do, but I would need to see the associated html file for the most accurate assessment.

1. For your own ease later, initiate your first 4 variables to something nullifying. This will help you debug later.

2. In your first if statement, in your for loop, check if the StudentExist variable is true first. This is more efficient (easier process) and will be better for the user too because they get the possible result faster.

3. I don't know your interface or html code, but it looks like it may be a good idea to nest your last if statement inside of the for loop.

I'm coming from mostly a C/C++ background and it is a good idea to always initiate your variables to something, especially null or 0. I don't see how it would affect your code negatively because it's already waiting for user input, and would over-ride upon entering those values anyway.

Demonstration:

var student; var search; var result = ''; var studentExist = false;

You initiated the last two variables here, but not the first two.

Now! I didn't see your link to Code Pen initially and I just had a look at it now. There are some things that are going to make your work a heck of a lot easier than making a student variable every time you have to enter new information - consider making a "class" so to speak, or a function. Here's what I mean:

Right now you have all your student data stored in an array like so: <script> var students = [ { name: 'Dave', track: 'Front End Development', achievements: 158, points: 14730 }, etc... </script> Try this instead: <script> function student(name, track, achievements, points){ this.name = name; this.track = track; this.achievements = achievements; this.points = points; } // This is your student object class, and can be re-used to suit whatever dynamic need you have. </script> To initiate, or use, a student object, you do this: <script> var Dave = new student("Dave", "Full Stack", 1568, 39); </script>

You did a great job, though. Is this your first search program?

Awesome job!

In c++ there is the vector class where you can use push and pop commands that will add to or take away from an array. Let me see what I can dig up about javascript in the same regard. I'm sure there is a solution for it.

Just a quick note - I presume that points and numbers in your application (if it were fully-functional) would be subject to change upon interaction and probably shouldn't be string data types, but number data types (in other words, the quotes should not be in quotes for your numerical variables =D).

Mmhmm... Now gimme that best answer award =D

Kidding, of course. It looks highly professional and easy to read as English. Can you re-link your updated Code Pen for this? I want to help you test it further and see what else we can optimize. I'm kind of having fun with it now. =D

Coolness!

Okay, so from a programmer standpoint, you've done your job. But from the user-standpoint, it may not be finished yet. What I mean is the prompt is persistent. It looks well and readable in my browser, on a 15 inch laptop, but that persistent prompt wouldn't be easy to read on small devices. Once your program finds a student, all prompt messages should probably go away.

The "issue" is somewhere here (even though you've really already completed the challenge): while (true) { search = prompt('Search student records: type a name or type "quit" to exit');

if (search === null || search.toLowerCase() === 'quit') {

```  }```

  ```for (var i = 0; i < students.length; i++) {```
   ```student = students[i];```
   ``` if (search.toLowerCase() === student.name.toLowerCase()) {```
    ```  result += getStudentReport(student);```
    ```  print(result);```
    ```  studentExist = true;```
  ```  }```
```  }```
```  result = '';```

  ```if (!studentExist) {```
  ```  result = 'No student named "' + search + '" was found.';```
    ```print(result);```
 ```}```
 ``` result = '';```
  ```studentExist = false;```
```}```
I think the solution might be to change the initial while loop's condition. I'm playing around with it now in Notepad++. 

P.S: I understand that typing 'quit' will exit the prompt but there's no suggestion of it. It should be more intuitive.

I would do the same thing. And I believe prompts and alert boxes can be styled in css. I recommend playing with it more. What track are you taking? I'm doing PHP Development.

Well when you're done, I'd like to work with you as a team to find a gap in the market where our skills can offer a solution. I'm mostly doing back-end things so I believe we would make a formidable team and then split the profits, of course. I'll put my email in my profile if you're interested.