How do I stop it from adding the last hyphen for the last element?

Question

I don't know what I am doing wrong, but I assume it is due to my last element adding an extra hyphen. Is there some other problem behind my code? Please do tell me. The way that I cannot see my output really annoys me because I can't troubleshoot or understand where I went wrong. All it does is tell me "Bummer: Try again!"

morse.py

class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern
    def __str__(self):
        str stuff = ''
        for i in self.pattern:
            if(i === '.'):
                stuff += 'dot-'
            elif(i === '_'):
                stuff += 'underscore-'



class S(Letter):
    def __init__(self):
        pattern = ['.', '.', '.']
        super().__init__(pattern)

Answer 1 · 2020-03-10T15:00:36Z

March 10, 2020 3:00pm

Yes, the extra hyphen is a problem, but there are a few others:

in Python, you don't put a type in front of a variable name to create it
there's no "===" operator in Python, use "==" for comparisons (are you also learning a different language?)
underscores in the pattern should be converted to the string "dash" instead of "underscore"
the method needs to return the string after it finishes making it

As for the hyphen, two possible fixes come to mind:

use a slice to remove the last character after the loop is done
build a list first, then convert it to a string while adding hyphens with "join"

Welcome to the Treehouse Community

Looking to learn something new?

Kong Tat Ong

Kong Tat Ong

How do I stop it from adding the last hyphen for the last element?

1 Answer

Steven Parker

Steven Parker