Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Ruby Ruby Booleans Build a Simple Todo List Program Finding Array Items

Posted by Courtney Glasgow
Courtney Glasgow
2,127 Points

how do you find array items for "build a simple todo list"?

i have no idea what's wrong with my code!!! so frustrating!!!!!

todo_list.rb 
class TodoList
  attr_reader :name, :todo_items

  def initialize(name)
    @name = name
    @todo_items = []
  end

  def add_item(name)
    todo_items.push(TodoItem.new(name))
  end

  def find_index(name)
    index = 0
    found = false
    todo_items.each do |todo_items|
    if todo_items.name == name
      found = true
    end

      if found 
        break
    else
      index +=1
      end
    end
      if found 
      return index
    else 
        return nil



end

2 Answers

David Moore
David Moore
13,916 Points
David Moore
David Moore
13,916 Points

First off, your indentation is probably making it harder for you see the issue. Always format your code.

So, I think you are missing an end

def find_index(name)
  index = 0
  found = false
  todo_items.each do |todo_items|
    if todo_items.name == name
      found = true
    end

    if found 
      break
    else
      index += 1
    end
  end

  if found 
    return index
  else 
      return nil
  end
end

And then you can clean this up a bit by doing the following:

def find_index(name)
  index = 0
  found = false
  todo_items.each do |todo_items|
    if todo_items.name == name
      found = true
      break
    else
      index += 1
    end
  end

  if found 
    index
  else 
    nil
  end
end

...or if you are playing code golf:

def find_index(name)
  index = 0
  found = false
  todo_items.each do |todo_items|
    if todo_items.name == name
      found = true
      break
    else
      index += 1
    end
  end
  found ? index : nil
end
Courtney Glasgow
Courtney Glasgow
2,127 Points
Courtney Glasgow
Courtney Glasgow
2,127 Points

thanks man

David Moore
David Moore
13,916 Points
David Moore
David Moore
13,916 Points

If it helped out please select it as the best answer. Thanks!