i am getting : Hmm, got back letters I wasn't expecting!... any tips people?

Question

def disemvowel(word):
    vowels = ("a", "e", "i", "o", "u", "A", "E", "I", "O", "U")
    for letter in word:
        if letter not in vowels:
            word += letter
            return word
```disemvowel.py
def disemvowel(word):
    vowels = ("a", "e", "i", "o", "u", "A", "E", "I", "O", "U")
    for letter in word:
        if letter not in vowels:
            word += letter
            return word
```

Unsubscribed User · Accepted Answer

Hey Greg,
Your thinking is in the right place, but the letters that you're adding to "word" are just getting tacked on to the end of whatever that word already is. For instance, if the word being passed into the function is "hello," you're returning "helloh" also because the return statement is also at the deepest indent level in the loop. So one loop through, you're already returning the string. An efficient way to go about this is just start a new empty string. We also have to move the return outside the loop. Here's some code that will solve:
python
def disemvowel(word):
    vowels = 'aeiouAEIOU'
    new_word = ''
    for letter in word:
        if letter not in vowels:
            new_word += letter # adding letters that aren't vowels to the empty new_word in order
    return new_word

Tim Sullivan · Answer

Think about the word variable... It's an arg to your function, and you do some stuff to it, then your function returns it. How has it changed? In other words, where are you removing the vowels from the word variable.

Welcome to the Treehouse Community

Looking to learn something new?

Gregorio Bernabel

Gregorio Bernabel

i am getting : Hmm, got back letters I wasn't expecting!... any tips people?

2 Answers

Unsubscribed User

Unsubscribed User

Gregorio Bernabel

Gregorio Bernabel

Tim Sullivan

Tim Sullivan