I don't understand where I did wrong for the movement challenge!

Question

I have commented my code, but i don't really get it where I did wrong.

movement.py

# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    h,v = direction # unpacking direction coordinates to horizontal and vertical

    # if vertical equals zero which means we need move player horizontally along with the x axis
    if v == 0 and h != 0:
        x += h
        # check if the player hit the wall after move
        if x > 9 or x < 0:
            hp -= 5 #oops hit the wall, hp lost

    # if horizontal equals zero which means we need move player vertically along with the y axis
    if h == 0 and v != 0:
        y += v
        if y > 9 or y < 0:
            hp -= 5 #oops hit the wall, hp lost
    return x, y, hp

Answer 1 · 2017-07-21T19:51:46Z

July 21, 2017 7:51pm

Hello,

in your code you check the movement direction, then add to the existing value, then check if the player hit a wall and reduce the hp. Therefore the player can move past the wall. I would approach the challenge by first checking if the player is moving into the wall and reduce the hp, returning the original x and y values along with the reduced hit point in each case, if after checking, no wall is hit, then adjust the coordinates.

def move(player, direction):
    x, y, hp = player
    x_move, y_move = direction

    if x_move == 1 and x == 9:
        hp -= 5
    elif x_move == -1 and x == 0:
        hp -= 5
    elif y_move == 1 and y == 9:
        hp -= 5
    elif y_move == -1 and y == 0:
        hp -= 5
    else:
        x += x_move
        y += y_move

    return x, y, hp

Welcome to the Treehouse Community

Looking to learn something new?

Henry Lin

Henry Lin

I don't understand where I did wrong for the movement challenge!

1 Answer

James J. McCombie

James J. McCombie

Henry Lin

Henry Lin