I get the wrong result ??

Question

My code apparently gives me the wrong teacher name and I don't know why. Help please!

teachers.py

# The dictionary will be something like:
# {'Jason Seifer': ['Ruby Foundations', 'Ruby on Rails Forms', 'Technology Foundations'],
#  'Kenneth Love': ['Python Basics', 'Python Collections']}
#
# Often, it's a good idea to hold onto a max_count variable.
# Update it when you find a teacher with more classes than
# the current count. Better hold onto the teacher name somewhere
# too!
#
# Your code goes below here.

def most_classes(dictionary):
  for key in dictionary:
    for key_2 in dictionary:
      if len(dictionary[key]) > len(dictionary[key_2]):
        most = key
      else:
        most = key_2
  return most

Answer 1 · 2016-05-19T09:56:34Z

May 19, 2016 9:56am

As far as I understood your problem, you want to return the teacher with maximum number of courses. But with this implementation, you will always get the teacher which comes last in the iteration and satisfies :

len(dictionary[key]) > len(dictionary[key_2])

You might want to do this:

most = dictionary.keys()[0]
for key in dictionary:
      if len(dictionary[key]) > len(dictionary[most]):
        most = key
return most

Welcome to the Treehouse Community

Looking to learn something new?

Maximilian Richly

Maximilian Richly

I get the wrong result ??

1 Answer

Ankit Bindal

Ankit Bindal

Maximilian Richly

Maximilian Richly