I think I went a little overboard...

Question

I feel like I might have over-organized the code that I wrote. I feel like it's usually a good idea to write clear programs, but I don't know whether or not I used conventions that are actually easy to digest for people actually used to reading code.

I was wondering if people could give some (brief) feedback about the readability and logical arrangement of the code I wrote.

For the sake of being able to preview the code all together, I simply dumped the story.js contents directly into the index.html <script> tags. I used http://htmledit.squarefree.com/ but I'm sure you can run it in the treehouse workspace if you like.

Also, while you leave feedback, you should copy-paste whatever story you got out of running my code. I think that'd be fun for everybody ^_~.

Thank you, thank you!~ I look forward to hearing from people soon.

<!doctype html>
<html>
  <head>
    <meta charset=utf-8>
    <title>Mad Glib</title>
    <style>p {font-family: monospace;}</style>
  </head> 
  <body>
    <h2>Mad Glib: The Movie Trailer Generator</h2>
       <script>
//Informs the user about the nature of the program to follow
alert("Salutations and welcome, my friend.\n\n\
Today we will be creating a story together.\n\
I have created a framework for a wonderful new movie intro,\n\
and you get to guide the plot of this exciting film of ours!\n\
Please be creative and follow the prompts as they appear.\n\n\
Also, be sure to have fun and copy-paste your results if you want to share!");

//Prompts the user to enter words for the story
var nounOne = prompt("Please list a POWERFUL GROUP OF PEOPLE in the field below and click \"OK\".");
var adjectiveOne = prompt("Please use an ADJECTIVE which DESCRIBES A POWERFUL THING.").toLowerCase();
var nounTwo = prompt("Please list a POWERFUL LIVING THING.").toLowerCase();
var nounThree = prompt("Please list a QUALITY which POWERFUL THINGS POSESS.").toLowerCase();
var nounFour = prompt("Please list A POWERFUL STRUCTURE.").toLowerCase();
var adjectiveTwo = prompt("Please list an ADJECTIVE which DESCRIBES A TERRIFYING OBJECT.").toLowerCase();
var nounFive = prompt("Please list A MYSTICAL ARTIFACT.").toLowerCase();
var nounSix = prompt("Please list a PLURAL FORM of THE MOST POWERFUL CREATURE.").toLowerCase();
var verbOne = prompt("Please list an INFINITIVE FORM OF A VERB that DESERVES TO BE CELEBRATED. Use the format \"to _____\"");
var nounSeven = prompt("Please list THE COOLEST HOLIDAY.");
var adjectiveThree = prompt("Please list an ADJECTIVE which DESCRIBES SUPER COOL THINGS.");
var storyTitle = adjectiveOne.toUpperCase() + " " + nounTwo.toUpperCase() + " and the " +  adjectiveTwo.toUpperCase() + " " + nounFive.toUpperCase();
var catchPhrase = prompt("Please write a CATCH PHRASE that a SUPER COOL, SUPER POWERFUL PERSON WOULD SAY WHEN THERE'S WORK TO DO.");

//Lets the user know that they are finished typing prompts
alert(
"Thank you for participating! Click \"OK\" to view movie trailer script that we came up  with together! \n\n\
Also, if you would like to see or hack away at any of my programming as it unfolds, feel  free to visit my GitHub at https://github.com/Aggredicus\n\n\
Enjoy your time programming!~"
);

//Structures the story into lines
var lineOne = "In a world... Where " + nounOne + " rule the planet.";
var lineTwo = "Only the most " + adjectiveOne + " " + nounTwo + " can make a difference.";
var lineThree = "To muster the " + nounThree + " necessary to overthrow the " + nounOne + " " + nounFour + ",";
var lineFour = "this " + nounTwo + " must seek out the planet's only remaining " + adjectiveTwo + " " + nounFive + ".";
var lineFive = "Armed with the " + nounFive + " and the " + nounThree + " of one thousand " + nounSix + ",";
var lineSix = "one " + nounTwo + " might be able " + verbOne + ".";
var lineSeven = "This " + nounSeven + ".";
var lineEight = "Get " + adjectiveThree + " for:";
var lineNine = storyTitle;
var lineTen = catchPhrase;

//Combines the various lines into a single story object
var completeStory = lineOne + "<br>" + lineTwo + "<br>" + lineThree + "<br>" + lineFour + "<br>" + lineFive + "<br>" + lineSix + "<br>" + lineSeven + "<br>" + lineEight + "<br>" + lineNine + "<br>" + lineTen;

//Wraps the story in a quickly editable CSS tag
var completeStory = "<p>" + completeStory + "</p>"

//Writes the complete story to the DOM
document.write(completeStory);

//NO LONGER USED
//Prints story to console to check for differences from DOM
//console.log(completeStory);a

    </script>
  </body>
</html>

Answer 1 · 2015-10-17T00:32:57Z

October 17, 2015 12:32am

This is beautifully written, keep up the enthusiasm and you will make a wonderful programmer.

Answer 2 · 2016-02-18T20:29:23Z

February 18, 2016 8:29pm

I couldn't get it to run. Has anyone else been able to?

Answer 3 · 2016-06-18T17:59:06Z

June 18, 2016 5:59pm

my results from playing with your code, which end up being super funny. I was just throwing random words into and it turned out to make a very funny story. http://screencast.com/t/Va21yznrDPjY

You did a great job writing it, although I thought it was bit long but it ended up being worth it.

Welcome to the Treehouse Community

Looking to learn something new?

Dillon Lee

Dillon Lee

I think I went a little overboard...

Gunhoo Yoon

Gunhoo Yoon

3 Answers

markevans3

markevans3

Dillon Lee

Dillon Lee

Lorraine Wheat

Lorraine Wheat

Grim Fandango

Grim Fandango

casthrademosthene

casthrademosthene