Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Even or Odd Loop

Posted by Joakim Vercaemst
Joakim Vercaemst
9,036 Points

I think I'm overlooking something. Somebody can help?

No idea whats wrong with my code

even.py 
import random
start = 5

def even_odd(num):
                # If % 2 is 0, the number is even.
                # Since 0 is falsey, we have to invert it with not.
    return not num % 2

while start:
    num = random.randomint(1, 99)
    if even_odd(num):
            print("{} is even".format(num))
        else:
            print("{} is odd".format(num))
    start = -1

1 Answer

Alexander Davison
Alexander Davison
65,469 Points
Alexander Davison
Alexander Davison
65,469 Points

Here's your code:

import random
start = 5

def even_odd(num):
                # If % 2 is 0, the number is even.
                # Since 0 is falsey, we have to invert it with not.
    return not num % 2

while start:
    num = random.randomint(1, 99)
    if even_odd(num):
            print("{} is even".format(num))
        else:
            print("{} is odd".format(num))
    start = -1

There are quite a few issues with it.

  • Your indentation isn't constant (for example the else clause is indented way more than your if clause)
  • You called the randomint() method on the random module but it doesn't exist. (You should use the randint method)
  • You are setting start to be negative 1 and that isn't the same as decrementing it.

This is the fixed version of your code:

import random
start = 5

def even_odd(num):
    # If % 2 is 0, the number is even.
    # Since 0 is falsey, we have to invert it with not.
    return not num % 2

while start:
    num = random.randint(1, 99)
    if even_odd(num):
        print("{} is even".format(num))
    else:
        print("{} is odd".format(num))
    start -= 1

I hope this helps. ~Alex