Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Tracking Data Using Objects The Build an Object Challenge, Part 2 Solution

Abdallah Tantawy
Abdallah Tantawy
1,276 Points
Posted by Abdallah Tantawy
Abdallah Tantawy
1,276 Points

I was wondering if this is a correct way for programming this. 

var students = [ 
  { 
    name: 'Dave',
    track: 'Front End Development',
    achievements: 158,
    points: 14730
  },
  {
    name: 'Jody',
    track: 'iOS Development with Swift',
    achievements: '175',
    points: '16375'
  },
  {
    name: 'Jordan',
    track: 'PHP Development',
    achievements: '55',
    points: '2025'
  },
  {
    name: 'John',
    track: 'Learn WordPress',
    achievements: '40',
    points: '1950'
  },
  {
    name: 'Trish',
    track: 'Rails Development',
    achievements: '5',
    points: '350'
  }
];

function printStudent( student ) {
  var HTMLcode = '<ol>Student: ' + students[student]['name'];
  HTMLcode += '<li>Track: ' + students[student]['track'] + '</li>';
  HTMLcode += '<li>Track: ' + students[student]['points'] + '</li>';
  HTMLcode += '<li>Track: ' + students[student]['achievements'] + '</li>';
  HTMLcode += '</ol>';
  return HTMLcode;
}

for(i = 0; i< students.length; i++){
  document.write(printStudent(i));
}

2 Answers

Chyno Deluxe
Chyno Deluxe
16,936 Points
Chyno Deluxe
Chyno Deluxe
16,936 Points

It is very clean and D.R.Y. code. Great job! The only thing I would alter is your students name within the ol tag. I would change the first line to maybe an h1 tag or strong tag and closing it in the same line and moving the ol tag to the second line.

var students = [ 
  { 
    name: 'Dave',
    track: 'Front End Development',
    achievements: 158,
    points: 14730
  },
  {
    name: 'Jody',
    track: 'iOS Development with Swift',
    achievements: '175',
    points: '16375'
  },
  {
    name: 'Jordan',
    track: 'PHP Development',
    achievements: '55',
    points: '2025'
  },
  {
    name: 'John',
    track: 'Learn WordPress',
    achievements: '40',
    points: '1950'
  },
  {
    name: 'Trish',
    track: 'Rails Development',
    achievements: '5',
    points: '350'
  }
];

function printStudent( student ) {
  var HTMLcode = '<strong>Student: ' + students[student]['name'] + '</strong>';
  HTMLcode += '<ol><li>Track: ' + students[student]['track'] + '</li>';
  HTMLcode += '<li>Track: ' + students[student]['points'] + '</li>';
  HTMLcode += '<li>Track: ' + students[student]['achievements'] + '</li>';
  HTMLcode += '</ol>';
  return HTMLcode;
}

for(i = 0; i< students.length; i++){
  document.write(printStudent(i));
}

Other than that your code is great!

Abdallah Tantawy
Abdallah Tantawy
1,276 Points
Abdallah Tantawy
Abdallah Tantawy
1,276 Points

Thank you for the response! I was also thinking about naming it something like studentID but didn't bother changing the name in all the cases.