Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (Retired) Dictionaries Teacher Stats

simon bao
simon bao
5,522 Points
Posted by simon bao
simon bao
5,522 Points

I'm getting an error of " `most_classes()` returned Dave McFarland, expected 'Jason Seifer'. " But don't understand why?

I'm slightly(alot) confused.

teachers.py 
# The dictionary will be something like:
# {'Jason Seifer': ['Ruby Foundations', 'Ruby on Rails Forms', 'Technology Foundations'],
#  'Kenneth Love': ['Python Basics', 'Python Collections']}
#
# Often, it's a good idea to hold onto a max_count variable.
# Update it when you find a teacher with more classes than
# the current count. Better hold onto the teacher name somewhere
# too!
#
# Your code goes below here.

def most_classes(teachers):
    teacher_name = ""
    class_list = []
    max_count = 0
    for a in teachers:
        for b in teachers.values():
            class_list.append(b)
            if len(class_list)>max_count:
                max_count = len(class_list)
                teacher_name = a
    return teacher_name
simon bao
simon bao
5,522 Points
simon bao
simon bao
5,522 Points

I've redone it and it works now!

def most_classes(teachers):
    teacher = ""
    classes = []
    max_count = 0
    for teacher in teachers:
        for class_name in teachers.values():
            classes.append(class_name)
            if len(classes)>max_count:
                max_count = len(classes)
                teacher = teacher
    return teacher