Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

Stefan Vaziri
Stefan Vaziri
17,453 Points
Posted by Stefan Vaziri
Stefan Vaziri
17,453 Points

I'm not exactly sure what this is asking me to do...

I added a new function (def main():) and moved all the functions from line 22 below under it but I'm not sure what I'm doing wrong. I moved the show_help() and shopping_list[] above def main(): but that doesn't seem right either.

shopping_list.py 
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

show_help()

shopping_list[]

def main():    
  while True:
    new_item = input("> ")
  if new_item == 'DONE':
     break
  elif new_item == 'HELP':
    show_help()
    continue
  elif new_item == 'SHOW':
    show_list(shopping_list)
    continue

add_to_list(shopping_list, new_item)

show_list(shopping_list)
  # make a list to hold onto our items

    # ask for new items  

    # be able to quit the app

1 Answer

Martin Cornejo Saavedra
Martin Cornejo Saavedra
18,132 Points
Martin Cornejo Saavedra
Martin Cornejo Saavedra
18,132 Points

You have to move everything below line 22 into main() function. You have to take proper care with the identation! show_help must be inside the main too, remember, there should be no code outside functions or classes.

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():  

  show_help()

  # make a list to hold onto our items
  shopping_list = []

  while True:
     #ask for new items
     new_item = input("> ")

     # be able to quit the app
     if new_item == 'DONE':
         break
     elif new_item == 'HELP':
         show_help()
         continue
     elif new_item == 'SHOW':
         show_list(shopping_list)
         continue

  add_to_list(shopping_list, new_item)

  show_list(shopping_list)
TaJuanna Williams
TaJuanna Williams
26,697 Points
TaJuanna Williams
TaJuanna Williams
26,697 Points

Thanks, Martin. The correct indentation worked.