Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Amanda Otero
Amanda Otero
7,410 Points

I'm not sure what I did wrong :(

Inside the major() setter method, set the student's major to a backing property "_major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "_major" backing property equal to 'None'.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(student){
    this._major = major;

    if (this._major === 'Senior' || this._major === 'Junior'){
      return student;
    } else {
      return 'None';
    }
  }
}

var student = new Student(3.9, 60);

1 Answer

Simon Coates
Simon Coates
8,481 Points
Simon Coates
Simon Coates
8,481 Points

A setter should set, I think. Not sure if it makes sense to include a return value or not. The parameter name for the setter shouldn't be student as this doesn't describe the inbound value. The values for the comparison (sophomore, senior, junior) come from level. It seemed to pass with

    set major(value){
      if (this.level === 'Senior' || this.level === 'Junior'){
          this._major = value;
      } else {
          this._major = 'none';
      }
    }