Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Peter Donaghy
Peter Donaghy
3,875 Points

I'm probably being really stupid here but why is this not accepting my setter method?

I am getting an error telling me my setter method is returning the wrong thing. I've tried the code in a different editor and it works. Have I maybe misunderstood the question? Thanks.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major){
        if(student.level === 'Junior' || student.level === 'Senior') {
            return this._major = major;
        } else {
            return this._major = 'None';
        }
      }
}

var student = new Student(3.9, 60);

1 Answer

jb30
jb30
44,807 Points

Try changing student.level to this.level so that if there are multiple students, each will check their own level and not the level in the student variable.

Values returned from a setter get ignored, so you can remove the return keyword.

Peter Donaghy
Peter Donaghy
3,875 Points

Ah, thank you! Yea that was right to change it to this.level. Thanks!