I'm sure I'm doing this all wrong, but I am trying to think of a better way of solving this double property method.

Question

If I'm not supposed to use self.dice to check the values of the dice, my other option was to use the _sets property but I can't seem to think of way of getting through it using that method. Please help. Thanks in advance

hands.py

from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):

    def __init__(self, *args, **kwargs):
        super().__init__(size=2, die_class=D6, *args, **kwargs)

    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

    @property
    def doubles(self, die_class):
        for item in die_class
            if self.dice[0] == self.dice[1]:
                return True
            else:
                return False

Answer 1 · 2020-03-09T15:52:29Z

March 9, 2020 3:52pm

You're working too hard!

the property should not take an argument
you don't need a loop
you can compare the list items directly
you can return the result of the comparison itself

    @property
    def doubles(self):
        return self[0] == self[1]

Welcome to the Treehouse Community

Looking to learn something new?

Sean Coutinho

Sean Coutinho

I'm sure I'm doing this all wrong, but I am trying to think of a better way of solving this double property method.

1 Answer

Steven Parker

Steven Parker

Sean Coutinho

Sean Coutinho