it should be working but i didnt get it

Question

def members(my_dict,my_list): count =0 keys =my_dict.keys() values =my_dict.values()

for key in keys: for element in my_list: if key ==element: count =count+1 for value in values: for element in my_list: if value == element: count =count+1

counts.py

# You can check for dictionary membership using the
# "key in dict" syntax from lists.

### Example
# my_dict = {'apples': 1, 'bananas': 2, 'coconuts': 3}
# my_list = ['apples', 'coconuts', 'grapes', 'strawberries']
# members(my_dict, my_list) => 2
def members(my_dict,my_list):
  count =0
  keys =my_dict.keys()
  values =my_dict.values()

  for key in keys:
    for element in my_list:
      if key ==element:
        count =count+1
  for value in values:
    for element in my_list:
      if value == element:
        count =count+1

Answer 1 · 2015-07-21T09:01:29Z

July 21, 2015 9:01am

hie ilker. I think you went a little bit overboard. Firstly there is no need to add the bit that checks for values since we have been told that its a list of keys which means there are no values in this list. You got the first part right that is defining the function and initializing count.

Now to check for the dictionary key that are also list member, we will use the for loop just like what you did but lets forget the variable that you used here and check for key membership in the dictionary directly as hinted in the code. Then we use an if statement to check if that key is also in the list, if its there we increment count by 1. Finally we return the value of count.

This should do the work.

def members(my_dict,my_list):

count = 0

for key in my_dict:

    if key in my_list:

    count = count + 1

return count

Welcome to the Treehouse Community

Looking to learn something new?

ilker senturk

ilker senturk

it should be working but i didnt get it

1 Answer

MUZ140889 Dephine Chenayi Chihota

MUZ140889 Dephine Chenayi Chihota