Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Stafford Dsouza
Stafford Dsouza
2,566 Points
Posted by Stafford Dsouza
Stafford Dsouza
2,566 Points

javascript and the dom

need some help on my code. dunno where im going wrong.

js/app.js 
var listItems = document.querySelectorAll("ul");
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(let i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

2 Answers

Joel Bardsley
Joel Bardsley
31,249 Points
Joel Bardsley
Joel Bardsley
31,249 Points

Hi Stafford, for your listItems variable you've selected the unordered list rather than the list items themselves.

While changing the "ul" in your querySelectorAll to "ul li" or just "li" would work, for best practices you should use the ul's id of rainbow to help you with your selection.

Good luck.

<noob />
<noob />
17,062 Points
<noob />
<noob />
17,062 Points

You are not selecting the li elements u only select the “ul” element. in order to select the list items inside the ul u need to call document.querySelectorAll(“ul li”);