Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialAmelia Nakimuli
6,636 PointsMake the code work
How can I better this code so that it will work?
import random
class Die:
def __init__(self, sides=2):
if sides < 2:
raise ValueError("Can't have fewer than two sides")
self.sides = sides
self.value = random.randint(1, sides)
def __int__(self):
return self.value
def __add__(self, other):
return int(self) + other
def __radd__(self, other):
return self + other
class D20(Die):
def __init__(self, *args, **kwargs):
super().__init__(sides=20, *args, **kwargs)
class Hand(list):
def __init__(self, num = None, *args, **kwargs):
super().__init__()
@classmethod
def roll(cls, size):
num = []
for item in range(size):
num.append(D20().value)
return num
@property
def total(self):
return sum(self)
1 Answer
Steven Parker
231,275 PointsTwo issues stand out at first glance:
- the list should contain complete D20 objects, not just their values
- instead of returning the list itself, the method should return a new instance with the list in it.