Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Posted by John Novak
John Novak
1,267 Points

move function help needed (challenge)

Hi all,

It seems that everything goes right in this code except for a player in the middle of the board. If a player is in the middle, I get this message: Bummer: Hmm, a player in the middle of the board took damage.

Does anyone know why?

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    a, b = direction
    if (x+a) or (y+b) < 0:
        hp -= 5
    elif (x+a) or (y+b) > 9:
        hp -= 5
    else:
        x = x+a
        y = y+b
    return x, y, hp

1 Answer

Steven Parker
Steven Parker
231,236 Points
Steven Parker
Steven Parker
231,236 Points

When you combine tests using logic operators, both sides of the logic operator need to be complete comparisons:

# so instead of this:
    if (x+a) or (y+b) < 0:
# you would write this:
    if (x+a) < 0 or (y+b) < 0:

Otherwise the rules for "truthiness" apply (anything other than 0 is "truthy").

John Novak
John Novak
1,267 Points

thank you so much! that was driving me crazy.