Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (Retired) Dictionaries Teacher Stats

My code only passes task 1... Sometimes...

I can't find the problem with my code.

But my most_classes function has a bug, since it will only return the correct answer to task 1, sometimes... Can someone pin-point the problem for me?

teachers.py
# The dictionary will be something like:
# {'Jason Seifer': ['Ruby Foundations', 'Ruby on Rails Forms', 'Technology Foundations'],
#  'Kenneth Love': ['Python Basics', 'Python Collections']}
#
# Often, it's a good idea to hold onto a max_count variable.
# Update it when you find a teacher with more classes than
# the current count. Better hold onto the teacher name somewhere
# too!
#
# Your code goes below here.
def most_classes(dictionary):
    teacher = ''
    max_count = 0

    for classes in dictionary.values():
        if (len(classes)) > max_count:
            max_count = (len(classes))

        for name in dictionary:
            teacher = name

        return teacher

def num_teachers(dictionary):
    total = 0
    for teachers in dictionary:
        total += 1

    return total

2 Answers

Martin Cornejo Saavedra
Martin Cornejo Saavedra
18,132 Points

I haven't tried this solution yet, but you can try this:

def most_classes(dictionary):
    teacher = ''
    max_count = 0

    for current_teacher, classes in dictionary.items():
        if (len(classes)) > max_count:
            max_count = (len(classes))
            teacher = current_teacher

    return teacher

def num_teachers(dictionary):
    total = 0
    for teachers in dictionary:
        total += 1

    return total

Yeah that code passes.