my code works fine in the workspace but not in the task

Question

can someone help me whats wrong in my covers_all code, it gives me the correct results in the workspace.
```sets.py
COURSES = {
    "Python Basics": {"Python", "functions", "variables",
                      "booleans", "integers", "floats",
                      "arrays", "strings", "exceptions",
                      "conditions", "input", "loops"},
    "Java Basics": {"Java", "strings", "variables",
                    "input", "exceptions", "integers",
                    "booleans", "loops"},
    "PHP Basics": {"PHP", "variables", "conditions",
                   "integers", "floats", "strings",
                   "booleans", "HTML"},
    "Ruby Basics": {"Ruby", "strings", "floats",
                    "integers", "conditions",
                    "functions", "input"}
}
def covers(arg):
    subject = []
    for key, value in arg.items():
        if value & arg:
            subject.append(key)
    return subject
def covers_all(arg):
    subject = []
    for key, value in COURSES.items():
        if len(arg.intersection(value)) == len(arg):
            subject.append(key)
    return subject
```

Jeff Muday · Accepted Answer

You were pretty close to a solution.  Look at my comments which indicate where changes are needed.
As a kind suggestion, you might want to consider using slightly better names than "arg", "key", and "value" as
these don't give the code reader any indication what the variable represents and contains.
I would suggest the "arg" variable would be better named "topics", and "key" be "coursename", and "value" be "coursetopics".   The reader of the code would easily understand your intention.
```python
def covers(arg):
    subject = []
    for key, value in COURSES.items(): # here iterate over courses key, values
        if arg & value:
            subject.append(key)
    return subject
def covers_all(arg):
    subject = []
    for key, value in COURSES.items():
        if value.issuperset(arg): # checks if "value" is a superset of arg
            subject.append(key)
    return subject
```

Welcome to the Treehouse Community

Looking to learn something new?

santosh kumar peddineni

santosh kumar peddineni

my code works fine in the workspace but not in the task

1 Answer

Jeff Muday

Jeff Muday