My modification for prompt_for_words function

Question

i modified the prompt_for_ words so it does :

only accept strings with two or more letters
only accept strings with letters within the range of letters in the given random word
only accept strings with number of letters equal or below number of letters of the given random word

def prompt_for_words(challenge):
    guesses = set()
    print("What words can you find in word '{}'".format(challenge))
    print("(Enter Q to Quit)")
    while True:
        try:
            guess = input("{} words > ".format(len(guesses)))
            if guess.upper() == 'Q':
                break
            if set(list(guess.lower())) <= set(list(challenge.lower())) and len(guess) >= 2 \ 
            and len(guess) <= len(challenge):
                print("BINGO!")
            else:
                raise AssertionError()
            guesses.add(guess.lower())
        except AssertionError:
            print("Oops! Try again :) ")
    return guesses

What are your thoughts ? and how can I improve it a bit further ? like how to make it accept strings with the exact number of letters within letters of the given word ? example: (right now ---> random word = word -----> it accepts guess = wowo , even there are only one 'o' and one 'w' in random word)

Answer 1 · 2019-03-30T22:30:39Z

March 30, 2019 10:30pm

Hi Noor,

There are a couple of things I want to point out (enumerated below), but they both point toward not explicitly using word length and sets of word letters as criteria for checking word validity. Instead, try comparing a list of the letters in the guess word against a list of the letters in the challenge word.

Another question associated with the "Out of This Word" video and its answers use this latter method instead. One of the answers suggests using sets, but another answer brings up a good argument against using sets, which I mention briefly below. Of course, even this latter method cannot check whether the guess is a "real" word that someone might find in a dictionary, whether or not it includes slang.

Some words are less than two letters long. For example, "a" and "I" are valid words. While the letter "i" isn't in any of the provided challenge words, "a" is in one of them: "learner".
What if the length of a guess word is less than the length of challenge word and all the letters in the set of letters in the guess word appear in the set of letters in the challenge word, but one of the letters in the guess word repeats and that letter does not repeat in the challenge word? For example, guessing "all" would pass your tests if the challenge word were "learner." However, we don't want "all" to pass because it has two "l"'s even though "learner" has only one.

URL to the discussion I reference: https://teamtreehouse.com/community/out-of-this-word-check-for-valid-words-is-this-the-best-way

Welcome to the Treehouse Community

Looking to learn something new?

Noor Elharty

Noor Elharty

My modification for prompt_for_words function

1 Answer

amyyxt

amyyxt