Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge

Angel Manuel Couso Jimenez
PLUS
Angel Manuel Couso Jimenez
Courses Plus Student 4,402 Points
Posted by Angel Manuel Couso Jimenez
Angel Manuel Couso Jimenez
Courses Plus Student 4,402 Points

My Solution, Is Correct?? Feedback is welcome

var html = '';

function randomRBGColor () {
  var red = Math.floor(Math.random() * 256 );
  var green = Math.floor(Math.random() * 256 );
  var blue = Math.floor(Math.random() * 256 );
  var rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  return '<div style="background-color:' + rgbColor + '"></div>';
}


for (var i = 0; i <= 9; i ++) {
  html += randomRBGColor();
}

document.write(html);
Mathew Yangang
Mathew Yangang
4,433 Points

It works ! thanks a lot. If only you can add more explanations so that i can understand it more better. But it works

1 Answer

Rasbin Rijal
PLUS
Rasbin Rijal
Courses Plus Student 4,940 Points
Rasbin Rijal
Rasbin Rijal
Courses Plus Student 4,940 Points

Hi Angel Manuel Couso Jimenez ,

Your code is correct and works very well. If you would like to improve further, you can follow the DRY (Don't Repeat Yourself) approach.

In your code, inside randomRGBColor function you have 3 variables : red, green and blue. You have repeated the code in those variable. You may keep the repeated code ( which is creating a random RGB value ) inside a separate function. Then, you can call that function from those variables.

Happy Learning! Rasbin