My solution to the last problem

Question

Here is my code to solve the adding empty tasks. The problem i am facing is that if i do not enter anything after the "else" statement. It adds multiple list items without any text in them. With the alert statement it works just fine. Please help
```javascript
var createNewTaskElement = function(taskString){
    //create listItem
    var listItem = document.createElement("li");
    // input checkbox 
    var checkbox = document.createElement("input");
    //create label 
    var label = document.createElement("label");
    //create text
    var editInput = document.createElement("input");
    //button.edit
    var editButton = document.createElement("button");
    //button.delete
    var deleteButton = document.createElement("button");
    //each elements needs modified 
  checkbox.type = "checkbox";
  editInput.type = "text";
  editButton.innerText = "Edit";
  editButton.className = "edit";
  deleteButton.innerText = "Delete";
  deleteButton.className = "delete";
  label.innerText = taskString;
  //each element needs appending append
    listItem.appendChild(checkbox);
    if (taskString !== ""){
    listItem.appendChild(label); 
    } else{
       alert("enter something")
    }
    listItem.appendChild(editInput);
    listItem.appendChild(editButton);
    listItem.appendChild(deleteButton);
  return listItem;
}
```

Eina Onting · Answer

What I did was add the if statement on the addTask function so it checks the value of taskInput before it even does any appending (or at least that's my understanding of it):
javascript
//Add Task
var addTask = function(){
    console.log('Add task');
    //Create a task -- new list item w/ text from #new-task and the elements inside
    //make sure the task has something there
    if(taskInput.value.length > 4){
        var listItem = createNewTaskEl(taskInput.value);
        //Append to Incomplete Task Handler
        incompleteTasksHolder.appendChild(listItem); 
        bindTaskEvents(listItem, completeTask);
        //make input blank after submitting
        taskInput.value = ''; 
    }else {
        alert('There was nothing there! Please type a task on the field.');
    }
};

I put 4 just because, asking if it's not an empty string should work too.

Welcome to the Treehouse Community

Looking to learn something new?

Rishit Shah

Rishit Shah

My solution to the last problem

1 Answer

Eina Onting

Eina Onting

Hunter G

Hunter G