Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Alfredo Patron
PLUS
Alfredo Patron
Courses Plus Student 994 Points
Posted by Alfredo Patron
Alfredo Patron
Courses Plus Student 994 Points

Need help with following function not working }} else {

var max = function (a,b) { if (a>b) { return max = a; }}

else { return max = b; }

script.js 
var max = function (a,b) {
  if (a>b) {
  return max = a;
  }}

   else {
    return max = b;
  }

1 Answer

Steven Parker
Steven Parker
231,236 Points
Steven Parker
Steven Parker
231,236 Points

When you return a value in JavaScript, you simply name the value being returned. The syntax you have here actually destroys the function and replaces it with a scalar variable:

  return max = a;  // this destroys the function "max" and re-uses the name as a variable
  return a;        // just do this instead

Also, the closing brace of the function is misplaced. It is currently following the "if" block, but needs to be moved to after the "else" block.