Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Michal Dobrzynski
Michal Dobrzynski
3,490 Points

Not sure if using the right query in this one, or selecting the wrong object, i.e. the list elements instead of parent

Not sure if using the right query in this one, or selecting the wrong object, i.e. the list elements instead of parent

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems = document.querySelectorAll("li");
  console.log(listItems);
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[1].style.color = colors[i];    
}

1 Answer

Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points
Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points

Hi Michal,

Inside the for loop you are picking always the second element of the listItems array "listItems[1]". Instead you should use the "i" counter of the loop like this: listItems[i]

Michal Dobrzynski
Michal Dobrzynski
3,490 Points

Many thanks Leandro, it seems that I need glasses after all :D

Managed to get it to work in the meantime by resetting the code and thus correcting the typo.