numbersgame.py trying to print statement if user inputs the same #? Help

Question

Hi,

I am trying to extend the number game a bit to where if a user inputs a number twice it gives them a message. When I run it the script ignores this command.

import random

def game():
# generate a random number between 1 -100
    secret_num=random.randint(1,100)

    while True:
# catch someone if the submit a non intergers  
        try:
            guess = int(input('Guess a number> '))
        except ValueError:
            print('{} That isn\'t a number'.format(guess))
# catch someone if they submit the same number
        already_guesses = []
        already_guesses.append(guess)
        if guess == already_guesses:
            print("You already guessed that number, try again")

# help with guesses and anounce if it is correct number!                
        else:
            if guess == secret_num:
                print("whooohoo! you guessed it, my number is {}".format(secret_num))
                number_guesses = len(guess) - already_guesses
                print("It took you {} guesses".format(number_guesses))
                break
            elif guess == already_guesses:
                print("You already guess that number, try again")
            elif guess < secret_num:
                print("You\'re getting hot, its a higher number")
            else:
                print("You\'re getting cold, try a lower number")

    else:   
        print("You didn't guess it, my number was {}".format(secret_num))  
    play_again = input("Do you wanna play again? y/n")
    if play_again != 'n':
        game()
    else:
        print("Bah Bye!")

game()

[MOD: added ```python markdown formatting -cf]

Answer 1 · 2016-03-28T04:00:21Z

March 28, 2016 4:00am

This issue is you are reinitializing the already_guesses list to empty each loop. Also, when checking if a guess is in already_guesses use the in keyword instead of the double-equals ==:

# catch someone if they submit the same number
        # already_guesses = []  # <-- move this statement outside and prior to the while-loop
        already_guesses.append(guess)
        if guess in already_guesses:  # <-- changed double-equal to in
            print("You already guessed that number, try again")

Answer 2 · 2016-03-28T04:20:52Z

March 28, 2016 4:20am

It didn't quite work. It then started to give same input error for every thing I inputed. I'm still trying to get it to work, but now I am getting an indentation error on that nested else: within the second to last if statement. second to last Else:

                   else:
                       guess in already_guesses
                       print("You already guessed that number, try again")

-----------------

import random

def game():
# generate a random number between 1 -100 and initiate repeat guest list
    secret_num=random.randint(1,100)
    already_guesses = []

    while True:
# catch someone if the submit a non intergers  
        try:
            guess = int(input('Guess a number> '))
        except ValueError:
            print('{} That isn\'t a number'.format(guess))
# catch someone if they submit the same number      


# help with guesses and anounce if it is correct number!                
        else:
            if guess == secret_num:
                print("whooohoo! you guessed it, my number is {}".format(secret_num))
                number_guesses = len(guess) - already_guesses
                print("It took you {} guesses".format(number_guesses))
                break
            elif guess == already_guesses:
                print("You already guess that number, try again")
            elif guess < secret_num:
                print("You\'re getting hot, its a higher number")
            elif print("You\'re getting cold, try a lower number"):

            else:
                guess in already_guesses
                print("You already guessed that number, try again")           
    else:   
        print("You didn't guess it, my number was {}".format(secret_num))  
    play_again = input("Do you wanna play again? y/n")
    if play_again != 'n':
        game()
    else:
        print("Bah Bye!")

game()

Answer 3 · 2016-03-28T04:21:32Z

March 28, 2016 4:21am

Thank you for your help by the way.

Answer 4 · 2016-03-28T04:28:21Z

March 28, 2016 4:28am

ok. I will reformat everything to try again.

Answer 5 · 2016-03-28T04:39:53Z

March 28, 2016 4:39am

I am trying to show patience. It kept giving me indentation errors until respaced everything. NowI am getting a syntax error on something that seems pretty straight forward.

Line 28 or "elif: print("You\'re getting cold, try a lower num"

The arrow is point to the colon next to the elif.

---------------------------

import random

def game():
# generate a random number between 1 -100 and initiate repeat guest list
    secret_num=random.randint(1,100)
    already_guesses = []

    while True:
# catch someone if the submit a non integers  
        try:
            guess = int(input('Guess a number> '))
        except ValueError:
            print('{} That isn\'t a number'.format(guess))  


# help with guesses and anounce if it is correct number! 
# catch someone if they submit the same number  
        else:
            if guess == secret_num:
                print("whooohoo! you guessed it, my number is {}".format(secret_num))
                number_guesses = len(guess) - already_guesses
                print("It took you {} guesses".format(number_guesses))
                break
            elif guess == already_guesses:
                print("You already guess that number, try again")
            elif guess < secret_num:
                print("You\'re getting hot, its a higher number")
            elif: 
                print("You\'re getting cold, try a lower number")   
            else:
                if guess in already_guesses:
                     print("You already guessed that number, try again")    
    else:   
        print("You didn't guess it, my number was {}".format(secret_num))  

    play_again = input("Do you wanna play again? y/n")
    if play_again != 'n':
        game()
    else:
        print("Bah Bye!")

game()

Answer 6 · 2016-03-28T04:44:06Z

March 28, 2016 4:44am

Ok, no more errors but I just cant seem to get it to fire off the command to catch repeated numbers. Here is the final code I have. Really appreciate this help.

import random

def game():
# generate a random number between 1 -100 and initiate repeat guest list
    secret_num=random.randint(1,100)
    already_guesses = []

    while True:
# catch someone if the submit a non intergers  
        try:
            guess = int(input('Guess a number> '))
        except ValueError:
            print('{} That isn\'t a number'.format(guess))  


# help with guesses and anounce if it is correct number! 
# catch someone if they submit the same number  
        else:
            if guess == secret_num:
                print("whooohoo! you guessed it, my number is {}".format(secret_num))
                number_guesses = len(guess) - already_guesses
                print("It took you {} guesses".format(number_guesses))
                break
            elif guess == already_guesses:
                print("You already guess that number, try again")
            elif guess < secret_num:
                print("You\'re getting hot, its a higher number")
            elif guess > secret_num:
                print("You\'re getting cold, try a lower number")   
            else:
                if guess in already_guesses:
                     print("You already guessed that number, try again")    
    else:   
        print("You didn't guess it, my number was {}".format(secret_num))  

    play_again = input("Do you wanna play again? y/n")
    if play_again != 'n':
        game()
    else:
        print("Bah Bye!")

game()

Answer 7 · 2016-03-28T05:51:01Z

March 28, 2016 5:51am

I'm not sure if you are still up, but ... No more errors . this script is not however doing two things.

Once the user guesses the number it should account for how many attempts a user made to guess the number - how many time he/she repeated a number.
It should give the message "YOu already guessed that number, try again when they input the same number twice or more than once.

It late here but I really need to figure this out withint eh next hour. I'm determined. I hope you can help.

import random

def game():
# generate a random number between 1 -100 and initiate repeat guest list
    secret_num=random.randint(1,10)
    already_guesses = []
    number_guesses = 0
    final_count = number_guesses - len(already_guesses)

    while True:
# catch someone if the submit a non intergers  
        try:
            guess = int(input('Guess a number> '))
        except ValueError:
            print('{} That isn\'t a number'.format(guess))
        number_guesses += 1
# help with guesses and announce if it is correct number! 
# catch someone if they submit the same number  
        if guess == secret_num:
            print("whooohoo! you guessed it, my number is {}".format(secret_num))

            print("It took you {} guesses".format(final_count))
            break
        elif guess < secret_num:
            print("You\'re getting hot, Try a higher number")
        elif guess > secret_num:
            print("You\'re getting cold, try a lower number")   
        elif guess in already_guesses:
            print("You already guessed that number, try again")
        else:
            already_guesses.append(guess)
    else:
        play_again = input("Do you wanna play again? y/n")
        if play_again != 'n':
            game()
        else:
            print("Bah Bye!")

game()

Answer 8 · 2016-03-28T14:17:05Z

March 28, 2016 2:17pm

so I've been working on this and decided to simplify a bit but am still feeling the pain regarding from control flow issues, indentation and now an elif syntax error. I"m trying ot understand how they all can affect one another. But what is most important to me is locking down this control flow issue. So here is where I am as of date. I am on several forums at this point, reading documentation and even emailing my wife's dad for help. Anyway, I appreciate any further insight that can be given.

A review:

I am trying to create a program that executes the following:

secret_num == generate a random # between 1-10
ask user to guess this number between 1-10
if guess == secret_num congratulate them and provide the number of guesses number_guesses it took (minus any duplicate guesses)
account for duplicate guesses 5. let them know if guess is too high or low

I am having typical new programmer problems with syntax, indentation and control flow. Right now I'm getting a syntax on the elif guess == secret num.

Otherwise I cannot get this code to account for duplicates to save my life. I would appreciate any help. Thank you .

import random

def game():
# generate a random number between 1 -100 and initiate repeat guess list
    secret_num=random.randint(1,10)
# initiate duplicate list and number of guesses
    already_guesses = []
    number_guesses = 0

    while True:
# ask for user guess
        guess = int(input('Guess a number from 1-10> '))
# help with guesses and announce if it is correct number!
# catch someone if they submit the same number
        if guess in already_guesses:
            print ("You already guessed that number, try again")
        already_guesses.append(guess)
        number_guesses += 1
        elif guess == secret_num:
            print("whooohoo! you guessed it, my number is {}".format(secret_num))
            print("It took you {} guesses".format(number_guesses - len([already_guesses])))
            break
        elif guess < secret_num:
            print("You\'re getting hot, try a higher number")
        else:
            guess > secret_num
            print("You\'re cold, try a lower number")
# ask if they want to play again
    else:
        play_again = input("Do you wanna play again? y/n")
        if play_again != 'n':
            game()
        else:
            print("Bah Bye!")

game()

This is the latest syntax error I'm encountering:

/Library/Frameworks/Python.framework/Versions/3.5/bin/python3.5 /Users/hanifahwalidah/PycharmProjects/hackbright/.idea/hacknumbers
  File "/Users/hanifahwalidah/PycharmProjects/hackbright/.idea/hacknumbers", line 18
    elif guess == secret_num:
       ^
SyntaxError: invalid syntax

Process finished with exit code 1

Welcome to the Treehouse Community

Looking to learn something new?

Hanifah W

Hanifah W

numbersgame.py trying to print statement if user inputs the same #? Help

8 Answers

Chris Freeman

Chris Freeman

Hanifah W

Hanifah W

-----------------

Chris Freeman

Chris Freeman

Hanifah W

Hanifah W

Hanifah W

Hanifah W

Hanifah W

Hanifah W

---------------------------

Chris Freeman

Chris Freeman

Hanifah W

Hanifah W

Chris Freeman

Chris Freeman

Hanifah W

Hanifah W

Chris Freeman

Chris Freeman

Chris Freeman

Chris Freeman

Hanifah W

Hanifah W

Chris Freeman

Chris Freeman