object oriented PHP basics step 5 of challenge 5

Hi there,

If you made it to the 5th task, you were doing okay, but I'm not sure where you are going with the 5th. First, I don't know where you are getting the term "public function," but I think that may be what is causing you some confusion.

The challenge asks "Create a method on Fish named getInfo that takes no parameters and returns a string that includes the common_name, flavor, and record_weight for the fish. When called on $bass, getInfo might return "A Largemouth Bass is an Excellent flavored fish. The world record weight is 22 pounds 5 ounces."

The word public is nowhere in there?

Anyways, you've already created a method (a function is called a method inside of a Class) called "__construct," now you just need to create one called "getInfo" that will return the stated string. And you need to delete the echo statement at the end, because the challenge did not ask for it... it just asks for you to create the method and return the string.

I think you may have just been over thinking the final part. The complete and corrected code is below.

<?php

class Fish {
  public $common_name;
  public $flavor;
  public $record_weight;

  function __construct($name, $flavor, $record) {
    $this->common_name = $name;
    $this->flavor = $flavor;
    $this->record_weight = $record;
  }
  function getInfo() {
    return "A $this->common_name is an $this->flavor flavored fish. The world record weight is $this->record_weight";
  }
}

$bass = new Fish('Largemouth Bass', 'Excellent', '22 pounds 5 ounces') 

?>

I hope this helps and makes sense. Keep Coding! :)

I've had to much JS lately, I was trying to do string concatenation lol. This is what I used

function getInfo() { return "A .$this->common_name is an .$this->flavor flavored fish. The world record weight is .$this->record_weight"; }

Jason Anders is mostly correct. You should use public function getInfo() because you should always expressly state whether methods or attributes are public, protected, or private.

With respect to your getInfo(), you can only have one return. If you wanted to do something like you did, you need to do it with a variable and return the variable.

Kinda confusing when Ted Sumner and Jason Anders are both Mods and give different takes on what the correct answer is.

Given 'public' is not requested and if nothing is entered, it is public anyway, then I don't see why you need to specify public.

Thanks Jason,

Might be a fairly basic question, but I guess I'll ask since it's confusing me....

In the last handful of tutorials, the PHP tags aren't closed, but the code's still working. There's always a <?php open tag, but never a ?> close tag. Any reason for that?