Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Antoni Majewski
Antoni Majewski
3,128 Points
Posted by Antoni Majewski
Antoni Majewski
3,128 Points

One dot output

Hello!

I have problem regarding this code: the output for "s" is "dot", instead of "dot-dot-dot". Why is that so?

Thanks!

morse.py 
class Letter:

    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for element in self:
            if element == ".":
                output.append("dot")
            elif element == "_":
                output.append("dash")
            return "-".join(output)

class S(Letter):
    def __init__(self):
        pattern = ['.', '.', '.']
        super().__init__(pattern)

2 Answers

KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points

Your return statement is indented too far. It should be lined up with for so that it is outside of the loop. Otherwise the code exits after the first element is checked which is why you only see one "dot"