Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Build a Simple Android App (2014) Improving Our Code Simple Refactoring: Using a Class

Tommy Binkley
Tommy Binkley
18,584 Points

Please Help!!

I did everything in the lesson that it told me to do. By cleaning up the code. And i have zero errors on android studio and then i went to run the app and it pops up fine then when i go to click the button the "Fact" goes blank and if i keep clicking it nothing happens and i cant get the other "Fun Facts" to pop up.

Could you please post your code so we can assist you?

Tommy Binkley
Tommy Binkley
18,584 Points

package tribe.funfacts;

import android.app.Activity; import android.os.Bundle; import android.view.Menu; import android.view.MenuItem; import android.view.View; import android.widget.Button; import android.widget.TextView;

import java.util.Random;

public class FunFactsActivity extends Activity {

private FactBook mFactBook = new FactBook();

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_fun_facts);

    //Declare our View variables and assign them the views from the layout file
    final TextView factLabel = (TextView) findViewById(R.id.factTextView);
    Button showFactButton = (Button) findViewById(R.id.showFactButton);
    View.OnClickListener listener = new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            String Fact = mFactBook.getFact();

            //Update the label with our dynamic fact
            factLabel.setText("");
        }
    };
    showFactButton.setOnClickListener(listener);

}

}

Tommy Binkley
Tommy Binkley
18,584 Points

package tribe.funfacts;

import java.util.Random;

/**

  • Created by admin on 4/5/15. */ public class FactBook {

    // Member variable (properties about the object public String[] mFacts = { "Ants stretch when they wake up in the morning.", "Ostriches can run faster than horses.", "Olympic gold medals are actually made mostly of silver.", "You are born with 300 bones; by the time you are an adult you will have 206.", "It takes about 8 minutes for light from the Sun to reach Earth.", "Some bamboo plants can grow almost a meter in just one day.", "The state of Florida is bigger than England.", "Some penguins can leap 2-3 meters out of the water.", "On average, it takes 66 days to form a new habit.", "Mammoths still walked the earth when the Great Pyramid was being built." };

    // Method (abilities; things the object can do) public String getFact(){

    String fact = "";
    //Randomly select a fact
    Random randomGenerator = new Random(); //Construct a new Random number generator
    int randomNumber = randomGenerator.nextInt(mFacts.length);
    
    fact = mFacts[randomNumber];
    
    return fact;
    

    } }

2 Answers

Hello,

In your onClickListener, you are using factLabel.setText(""); which is setting your label to be an empty string. Instead of "" you want to pass in your fact.

Tommy Binkley
Tommy Binkley
18,584 Points

Thanks so much it worked!! I had String Fact = mFactBook.getFact(); instead of String fact = mFactBook.getFact(); with a lower case f so when i did what you told me to and it came up an error then i changed it to lower case and it worked thanks!!

This is somewhat related, so I'll post here in case it helps someone. I had everything on that line typed correctly, but I had left the "" around the word fact in the parens. So I was getting the word fact popping up every time I hit the button. I saw the answer James posted and it gave me my a-ha moment.