Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Number Game App String length

Posted by Victor Katsande
Victor Katsande
3,094 Points

Please help. Having trouble with the return function.

the code is supposed to "return" the message in quotes depending on the length of the string. otherwise it returns True. i have tried using PRINT instead of return, and it's still not working.

strlen.py 
def just_right(string):
    for item in string:
        if len(item) < 5:
            return("Your string is too short")
        elif len(item) > 5:
            return("Your string is too long")
        else:
            return True

1 Answer

Antonio De Rose
Antonio De Rose
20,885 Points
Antonio De Rose
Antonio De Rose
20,885 Points 
def just_right(string):
    for item in string:
        if len(item) < 5:
            return("Your string is too short")
        elif len(item) > 5:
            return("Your string is too long")
        else:
            return True

# your logic is fine, except for a just one place,
# your for loop is redundant, you have to take that loop out
# the scenario, not the question does not have ask for it