Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Break

Posted by Andrey Klimushin
Andrey Klimushin
3,614 Points

Pls help me optimize the code

the code is to long to run

breaks.py 
def loopy(items):
    # Code goes here 
    loopy=[]
    while True:
      if items=='STOP':
        break
    for items in loopy:
      print(items)

2 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,441 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,441 Points

The issue is if your code is run with a list items that does not have a "STOP" among them, the while loop will never terminate. The while loop isn't necessary. A for loop can walk down the items list printing until a "STOP" is seen. If not seen, the function completes naturally.

def loopy(items):
    # check each item in the items list
    for item in items:
        # check if this item is STOP
        if item == 'STOP':
            # end the for loop
            break
        # otherwise print
        print(item)
Andrey Klimushin
Andrey Klimushin
3,614 Points
Andrey Klimushin
Andrey Klimushin
3,614 Points

That`s make sense now. Thanks again Chris!