Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Chigozie Ofodike
Chigozie Ofodike
11,197 Points
Posted by Chigozie Ofodike
Chigozie Ofodike
11,197 Points

Problem selecting very specific elements

I was told to select and assign links that were found in children of a nav element, like so <nav> <ul> <li><a href="index.html" class="selected">Portfolio</a></li> <li><a href="about.html">About</a></li> <li><a href="contact.html">Contact</a></li> </ul> </nav>

i've tried different methods and i still havent been able to select the links there. I was aiming to use the "document.querySelectorAll" method, but the most specific and best element i was able to get was the entire li element I did it using "document.querySelectorAll('nav > ul > li');" can someone help me with my code or give me a better selector?

js/app.js 
let navigationLinks;
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected nav_links">Portfolio</a></li>
          <li><a href="about.html" class="nav_links">About</a></li>
          <li><a href="contact.html"class="nav_links" >Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

2 Answers

Yazan Alhalabi
Yazan Alhalabi
10,483 Points
Yazan Alhalabi
Yazan Alhalabi
10,483 Points

querySelectorAll is a good solution, i was able to target the links and images in footer for the challenge. let navigationLinks = document.querySelectorAll('nav a'); let galleryLinks = document.querySelectorAll('#gallery a'); let footerImages = document.querySelectorAll('footer img');

Hope it helps!

Yazan Alhalabi
Yazan Alhalabi
10,483 Points
Yazan Alhalabi
Yazan Alhalabi
10,483 Points

by the way, in the first question you have to select the links (a) and not the list(li) according to the question.

samirawad
samirawad
9,294 Points
samirawad
samirawad
9,294 Points

Hi You can add id to your links

      <li><a id="portfolio" href="index.html" class="selected nav_links">Portfolio</a></li>
      <li><a id="about" href="about.html" class="nav_links">About</a></li>
      <li><a id="contact" href="contact.html"class="nav_links" >Contact</a></li>

then in java script

document.querySelector('about').href="newpage.html";