Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialBibiana Balbuena Barbosa
14,768 PointsQuery Selector challenge, can't do it
as my understanding either of the following syntax should work: var listItems = getElementById('rainbow') or var listItems = querySelectorAll('#rainbow')
What am I doing wrong?
var listItems = document.querySelectorAll('#rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];
for(var i = 0; i < colors.length; i ++) {
listItems.[i].style.color = colors[i];
}
<!DOCTYPE html>
<html>
<head>
<title>Rainbow!</title>
</head>
<body>
<ul id="rainbow">
<li>This should be red</li>
<li>This should be orange</li>
<li>This should be yellow</li>
<li>This should be green</li>
<li>This should be blue</li>
<li>This should be indigo</li>
<li>This should be violet</li>
</ul>
<script src="js/app.js"></script>
</body>
</html>
5 Answers
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 PointsYou are grabbing <ul> instead of <li>. You need an array of html elements(<li>), not a list of #rainbow. Having said that I had similar problem with this particular challenge as the instruction is a bit unclear.
Bibiana Balbuena Barbosa
14,768 PointsThanks a lot!! I get it now :)
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 Pointsvar listItems = document.querySelectorAll('#rainbow li');
Bibiana Balbuena Barbosa
14,768 PointsI've remove the dote, still doesn't work. But thanks for the hint.
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 PointsCheo wanted to draw your attention to the fact that you need to grab a collection of html items, which is an array instead of just one item.
Christine Treacy
Full Stack JavaScript Techdegree Graduate 18,412 PointsThank you Piotr. I never would have figured this out. I was really stuck with the same issue as OP.
Piotr Manczak
Front End Web Development Techdegree Graduate 29,363 PointslistItems[i] instead of listItems.[i]
Christine Treacy
Full Stack JavaScript Techdegree Graduate 18,412 PointsYes, I had the correct, thank you. I just didn't have the li listed after rainbow. That's what you helped me with. Thanks again!
Cheo R
37,150 PointsCheo R
37,150 PointslistItems.[i]
Notice anything about the code above?