Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Posted by Max Palmer
Max Palmer
2,920 Points

Questions regarding classmethods and self.append

Not sure what is going wrong here. Think I may be something to do with the append, as previously I noted that it only works with the self argument, so it would update the current instance (hand) with the dice.

However on this occasion it is a class method so unsure how to settle using self in class method.

The errror I get is cannot find the lengthof 'Hand', which I assume is refering to the Hand in Hand(list)

dice.py 
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py 
from dice import D20

class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, size):
        super().__init__()

        for _ in range(size):
            cls.append(D20())

1 Answer

Steven Parker
Steven Parker
231,275 Points
Steven Parker
Steven Parker
231,275 Points

Here's a few hints:

  • you won't need to call "super" for anything
  • the "cls" parameter refers to the class itself and has no "append" method
  • but you can use "cls" to create a new instance, which does have "append"
  • the method needs to eventually "return" the new instance
Max Palmer
Max Palmer
2,920 Points

That was really useful, I took that on and rewatched the video about class methods then rewrote the hands code. There still seems to be an error however. Am i missing something out?

class Hand(list): @property def total(self): return sum(self)

@classmethod
def roll(cls, size):
    numbers = []

    for _ in range(size):
        numbers.append(D20())

    return cls(numbers)
Max Palmer
Max Palmer
2,920 Points

disregard previous comment, I left out the import bit. Thanks for your help and I hope to give back to the community as much as you helped me.