Re.Expressions

Question

What am i missing here? Any advice?

negate.py

import re

string = '1234567890'

def good_numbers(string):
  return re.findall(r'[\w\d][^567]', string, re.I)

Answer 1 · 2015-08-15T05:48:56Z

August 15, 2015 5:48am

Hi Mar,

There are two issues with your solution. First, the task asks only to create a variable named good_numbers, not a function.

Second, your regex is overly complicated for the task. By combining two character sets your regex r'[\w\d][^567]' says:

`[any word or decimal character][not followed by 5 6 or 7]' this means the "7" will still be found "good" because it is follow by "8".

Your regex need only say `[not a 5, 6 or 7]'. This can be accomplished using:

good_numbers = re.findall(r'[^567]', string)

The re.I is not needed since there is no character case to ignore.

Best of luck. Keep Coding!

Welcome to the Treehouse Community